Hugo Nijhuis HugoNijhuis
0 Followers · 0 Following
  • Joined on 2025-12-29
Repositories Projects Packages Public Activity Starred Repositories
HugoNijhuis deleted branch issue-62- from flowmade-one/aether 2026-01-13 21:39:09 +00:00
HugoNijhuis pushed to main at flowmade-one/aether 2026-01-13 21:39:09 +00:00
46e1c44017 test(event): Add comprehensive VersionConflictError tests and retry pattern examples
HugoNijhuis commented on pull request flowmade-one/aether#135 2026-01-13 21:27:46 +00:00
feat(event-sourcing): Publish EventStored after successful SaveEvent

Code Review: Approved ✓

All review feedback has been successfully addressed:

Fixes verified:

  1. Duplicate blank line removed from event.go
  2. EventStored uses original event.Timestamp…
HugoNijhuis commented on pull request flowmade-one/aether#137 2026-01-13 21:27:09 +00:00
test(event): Add comprehensive VersionConflictError tests and retry pattern examples

Code Review: Approved ✓

Fixes applied successfully. All 9 comprehensive VersionConflictError tests pass and cover the required scenarios:

  • Error message formatting with all context fields -…
HugoNijhuis commented on pull request flowmade-one/aether#136 2026-01-13 21:27:08 +00:00
docs: Verify and document append-only immutability guarantees

Code Review: Approved ✓

Error handling for json.Marshal and json.Unmarshal properly implemented with appropriate panic behavior documented. All tests passing including new immutability…

HugoNijhuis commented on pull request flowmade-one/aether#135 2026-01-13 21:25:15 +00:00
feat(event-sourcing): Publish EventStored after successful SaveEvent

Fixed review feedback✓

  • Removed duplicate blank line in event.go
  • Use original event timestamp for EventStored consistency
  • Fixed MockEventBroadcaster channel panic issue
  • Added JetStreamEven…
HugoNijhuis created branch issue-61-untitled in flowmade-one/aether 2026-01-13 21:25:15 +00:00
HugoNijhuis pushed to issue-61-untitled at flowmade-one/aether 2026-01-13 21:25:15 +00:00
5223cf136a fix: address review feedback
0f89b07c0b feat(event sourcing): Publish EventStored event after successful SaveEvent
Compare 2 commits »
HugoNijhuis commented on pull request flowmade-one/aether#137 2026-01-13 21:24:52 +00:00
test(event): Add comprehensive VersionConflictError tests and retry pattern examples

Fixed review feedback

  • Removed redundant newline from fmt.Println
  • Added 9 comprehensive VersionConflictError tests
  • All tests pass successfully
HugoNijhuis created branch issue-62-untitled in flowmade-one/aether 2026-01-13 21:24:51 +00:00
HugoNijhuis pushed to issue-62-untitled at flowmade-one/aether 2026-01-13 21:24:51 +00:00
d929729d79 fix: address review feedback
f16a7c6237 docs: Add VersionConflictError retry pattern examples
Compare 2 commits »
HugoNijhuis commented on pull request flowmade-one/aether#136 2026-01-13 21:24:40 +00:00
docs: Verify and document append-only immutability guarantees

Fixed review feedback

  • Added error handling for json.Marshal
  • Added error handling for json.Unmarshal
  • Documented error behavior with panic for invalid Event structures
HugoNijhuis created branch issue-60-untitled in flowmade-one/aether 2026-01-13 21:24:38 +00:00
HugoNijhuis pushed to issue-60-untitled at flowmade-one/aether 2026-01-13 21:24:38 +00:00
84fe185285 fix: address review feedback on error handling
69da1d800e docs: Verify and document append-only event guarantees
Compare 2 commits »
HugoNijhuis commented on pull request flowmade-one/aether#136 2026-01-13 20:59:37 +00:00
docs: Verify and document append-only immutability guarantees

Code Review: Changes Requested

Issues:

  1. store/memory.go:30-32 - Errors from json.Marshal and json.Unmarshal are silently discarded. While Event should always be JSON-marshallable,…
HugoNijhuis commented on pull request flowmade-one/aether#135 2026-01-13 20:58:58 +00:00
feat(event-sourcing): Publish EventStored after successful SaveEvent

Code Review: Changes Requested

Issues:

  1. event.go:169 - Duplicate blank line: empty line at 169 is unnecessary, creates inconsistent spacing
  2. store/memory.go:75 and `store/jetstream…
HugoNijhuis commented on pull request flowmade-one/aether#137 2026-01-13 20:58:58 +00:00
test(event): Add comprehensive VersionConflictError tests and retry pattern examples

Code Review: Changes Requested

Issues:

  1. examples/version_conflict_retry.go:325 - Redundant newline in fmt.Println: remove \n from string literal (fmt.Println already adds newline) 2.…
HugoNijhuis created pull request flowmade-one/aether#137 2026-01-13 20:46:30 +00:00
test(event): Add comprehensive VersionConflictError tests and retry pattern examples
HugoNijhuis created branch issue-62- in flowmade-one/aether 2026-01-13 20:46:26 +00:00
HugoNijhuis pushed to issue-62- at flowmade-one/aether 2026-01-13 20:46:26 +00:00
46e1c44017 test(event): Add comprehensive VersionConflictError tests and retry pattern examples