Hugo Nijhuis HugoNijhuis
0 Followers · 0 Following
  • Joined on 2025-12-29
Repositories Projects Packages Public Activity Starred Repositories
HugoNijhuis commented on pull request flowmade-one/aether#136 2026-01-13 21:24:40 +00:00
docs: Verify and document append-only immutability guarantees

Fixed review feedback

  • Added error handling for json.Marshal
  • Added error handling for json.Unmarshal
  • Documented error behavior with panic for invalid Event structures
HugoNijhuis pushed to issue-60-untitled at flowmade-one/aether 2026-01-13 21:24:38 +00:00
84fe185285 fix: address review feedback on error handling
69da1d800e docs: Verify and document append-only event guarantees
Compare 2 commits »
HugoNijhuis created branch issue-60-untitled in flowmade-one/aether 2026-01-13 21:24:38 +00:00
HugoNijhuis commented on pull request flowmade-one/aether#136 2026-01-13 20:59:37 +00:00
docs: Verify and document append-only immutability guarantees

Code Review: Changes Requested

Issues:

  1. store/memory.go:30-32 - Errors from json.Marshal and json.Unmarshal are silently discarded. While Event should always be JSON-marshallable,…
HugoNijhuis commented on pull request flowmade-one/aether#137 2026-01-13 20:58:58 +00:00
test(event): Add comprehensive VersionConflictError tests and retry pattern examples

Code Review: Changes Requested

Issues:

  1. examples/version_conflict_retry.go:325 - Redundant newline in fmt.Println: remove \n from string literal (fmt.Println already adds newline) 2.…
HugoNijhuis commented on pull request flowmade-one/aether#135 2026-01-13 20:58:58 +00:00
feat(event-sourcing): Publish EventStored after successful SaveEvent

Code Review: Changes Requested

Issues:

  1. event.go:169 - Duplicate blank line: empty line at 169 is unnecessary, creates inconsistent spacing
  2. store/memory.go:75 and `store/jetstream…
HugoNijhuis created pull request flowmade-one/aether#137 2026-01-13 20:46:30 +00:00
test(event): Add comprehensive VersionConflictError tests and retry pattern examples
HugoNijhuis created branch issue-62- in flowmade-one/aether 2026-01-13 20:46:26 +00:00
HugoNijhuis pushed to issue-62- at flowmade-one/aether 2026-01-13 20:46:26 +00:00
46e1c44017 test(event): Add comprehensive VersionConflictError tests and retry pattern examples
HugoNijhuis created pull request flowmade-one/aether#136 2026-01-13 20:45:35 +00:00
docs: Verify and document append-only immutability guarantees
HugoNijhuis created pull request flowmade-one/aether#135 2026-01-13 20:45:30 +00:00
feat(event-sourcing): Publish EventStored after successful SaveEvent
HugoNijhuis created branch issue-60- in flowmade-one/aether 2026-01-13 20:45:30 +00:00
HugoNijhuis pushed to issue-60- at flowmade-one/aether 2026-01-13 20:45:30 +00:00
78aaea9330 docs: Verify and document append-only immutability guarantees
HugoNijhuis created branch issue-61- in flowmade-one/aether 2026-01-13 20:45:15 +00:00
HugoNijhuis pushed to issue-61- at flowmade-one/aether 2026-01-13 20:45:15 +00:00
8c5ac500b6 feat(event-sourcing): Publish EventStored after successful SaveEvent
HugoNijhuis deleted branch issue-61-untitled from flowmade-one/aether 2026-01-13 20:41:36 +00:00
HugoNijhuis deleted branch issue-62-untitled from flowmade-one/aether 2026-01-13 20:41:34 +00:00
HugoNijhuis deleted branch issue-60-untitled from flowmade-one/aether 2026-01-13 20:41:31 +00:00
HugoNijhuis pushed to issue-60-untitled at flowmade-one/aether 2026-01-13 20:26:21 +00:00
69da1d800e docs: Verify and document append-only event guarantees
HugoNijhuis created branch issue-60-untitled in flowmade-one/aether 2026-01-13 20:26:21 +00:00