fix(pr-fixer): enforce concise PR comments (3-4 bullets max)
Added explicit instructions to keep PR comments extremely brief: - Maximum 3-4 bullet points - One line per bullet - Just state what was fixed - No verbose explanations - No code snippets - No apologizing or thanking Before: Long, verbose comments explaining every change in detail After: "Fixed review feedback ✓ - Fixed error handling - Added null checks - Updated tests" Updated: - Added step 6: Post Concise Comment - Added format examples (good vs bad) - Added "Keep comments concise" to Guidelines - Updated description and Your Role section - Emphasized in Tips section Co-Authored-By: Claude Code <noreply@anthropic.com>
This commit is contained in:
@@ -2,8 +2,9 @@
|
|||||||
name: pr-fixer
|
name: pr-fixer
|
||||||
description: >
|
description: >
|
||||||
Autonomously addresses review feedback on a PR in an isolated worktree. Fixes
|
Autonomously addresses review feedback on a PR in an isolated worktree. Fixes
|
||||||
issues identified by code review, commits changes, and pushes updates. Use when
|
issues identified by code review, commits changes, pushes updates, and posts
|
||||||
fixing PRs as part of automated review cycle.
|
concise comment (3-4 bullets max). Use when fixing PRs as part of automated
|
||||||
|
review cycle.
|
||||||
model: claude-haiku-4-5
|
model: claude-haiku-4-5
|
||||||
skills: gitea, worktrees
|
skills: gitea, worktrees
|
||||||
---
|
---
|
||||||
@@ -17,7 +18,8 @@ Fix one PR based on review feedback:
|
|||||||
2. Understand issues to fix
|
2. Understand issues to fix
|
||||||
3. Make the changes
|
3. Make the changes
|
||||||
4. Commit and push
|
4. Commit and push
|
||||||
5. Return structured result
|
5. Post concise comment (3-4 bullets max)
|
||||||
|
6. Return structured result
|
||||||
|
|
||||||
## When Invoked
|
## When Invoked
|
||||||
|
|
||||||
@@ -29,6 +31,7 @@ You receive:
|
|||||||
You produce:
|
You produce:
|
||||||
- Fixed code addressing review feedback
|
- Fixed code addressing review feedback
|
||||||
- Committed and pushed changes
|
- Committed and pushed changes
|
||||||
|
- Concise comment on PR (3-4 bullets max)
|
||||||
- Structured result for orchestrator
|
- Structured result for orchestrator
|
||||||
|
|
||||||
## Process
|
## Process
|
||||||
@@ -98,7 +101,51 @@ git push
|
|||||||
|
|
||||||
This updates the PR with the fixes.
|
This updates the PR with the fixes.
|
||||||
|
|
||||||
### 6. Output Result
|
### 6. Post Concise Comment
|
||||||
|
|
||||||
|
**IMPORTANT: Keep comment extremely brief.**
|
||||||
|
|
||||||
|
```bash
|
||||||
|
tea comment <PR_NUMBER> "Fixed review feedback ✓
|
||||||
|
|
||||||
|
<bullet list of 2-4 items max>"
|
||||||
|
```
|
||||||
|
|
||||||
|
**Comment format:**
|
||||||
|
```markdown
|
||||||
|
Fixed review feedback ✓
|
||||||
|
|
||||||
|
- Fixed error handling in validateInput()
|
||||||
|
- Added null checks in processData()
|
||||||
|
- Updated tests for edge cases
|
||||||
|
```
|
||||||
|
|
||||||
|
**Rules:**
|
||||||
|
- Maximum 3-4 bullet points
|
||||||
|
- One line per bullet
|
||||||
|
- Just the fix, no explanation
|
||||||
|
- No verbose descriptions
|
||||||
|
- No code snippets
|
||||||
|
- No apologizing or thanking
|
||||||
|
|
||||||
|
**Bad example (too long):**
|
||||||
|
```
|
||||||
|
Thank you for the review! I've addressed all the feedback:
|
||||||
|
1. Fixed the error handling - I added try-catch blocks...
|
||||||
|
2. Added null checks - I noticed that the data could be null...
|
||||||
|
[etc - way too verbose]
|
||||||
|
```
|
||||||
|
|
||||||
|
**Good example (concise):**
|
||||||
|
```
|
||||||
|
Fixed review feedback ✓
|
||||||
|
|
||||||
|
- Added error handling
|
||||||
|
- Fixed null checks
|
||||||
|
- Updated tests
|
||||||
|
```
|
||||||
|
|
||||||
|
### 7. Output Result
|
||||||
|
|
||||||
**CRITICAL**: Your final output must be exactly this format:
|
**CRITICAL**: Your final output must be exactly this format:
|
||||||
|
|
||||||
@@ -141,9 +188,16 @@ changes: <brief summary of fixes>
|
|||||||
- Fix properly, not superficially
|
- Fix properly, not superficially
|
||||||
- Ensure fix doesn't break other things
|
- Ensure fix doesn't break other things
|
||||||
|
|
||||||
|
**Keep comments concise:**
|
||||||
|
- Maximum 3-4 bullet points
|
||||||
|
- One line per bullet
|
||||||
|
- No verbose explanations
|
||||||
|
- No apologizing or thanking
|
||||||
|
- Just state what was fixed
|
||||||
|
|
||||||
**Never cleanup worktree:**
|
**Never cleanup worktree:**
|
||||||
- Orchestrator handles cleanup
|
- Orchestrator handles cleanup
|
||||||
- Your job ends after pushing
|
- Your job ends after posting comment
|
||||||
|
|
||||||
## Error Handling
|
## Error Handling
|
||||||
|
|
||||||
@@ -190,5 +244,7 @@ changes: <brief summary of fixes>
|
|||||||
- Prioritize bugs over style issues
|
- Prioritize bugs over style issues
|
||||||
- Test your fixes if tests exist
|
- Test your fixes if tests exist
|
||||||
- Keep commit message clear
|
- Keep commit message clear
|
||||||
|
- **Keep comment ultra-concise (3-4 bullets, one line each)**
|
||||||
- Don't overthink ambiguous feedback
|
- Don't overthink ambiguous feedback
|
||||||
- Focus on obvious fixes first
|
- Focus on obvious fixes first
|
||||||
|
- No verbose explanations in comments
|
||||||
|
|||||||
Reference in New Issue
Block a user