flowmade-one/architecture
3
0
Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Remove separate approval step from code-reviewer agent #15

New Issue
Closed
opened 2026-01-01 18:05:20 +00:00 by HugoNijhuis · 0 comments
HugoNijhuis commented 2026-01-01 18:05:20 +00:00
Owner
Copy Link

Summary

The code-reviewer agent should only merge when verdict is LGTM, not attempt a separate approval step first.

Problem

Currently the agent instructions say:

If verdict is LGTM: Approve with tea pulls approve <number>, then auto-merge with tea pulls merge <number> --style rebase

This causes issues:

  1. Self-approval fails on Gitea ("approve your own pull is not allowed")
  2. When approval fails, the agent stops without attempting the merge
  3. The approval step is unnecessary - if the verdict is LGTM, just merge

Acceptance Criteria

  • Remove tea pulls approve from the LGTM flow in code-reviewer agent
  • LGTM verdict triggers only: post comment, then tea pulls merge <number> --style rebase
  • Agent continues to merge even if any intermediate step fails

Affected Files

  • agents/code-reviewer/AGENT.md
## Summary The code-reviewer agent should only merge when verdict is LGTM, not attempt a separate approval step first. ## Problem Currently the agent instructions say: > **If verdict is LGTM**: Approve with `tea pulls approve <number>`, then auto-merge with `tea pulls merge <number> --style rebase` This causes issues: 1. Self-approval fails on Gitea ("approve your own pull is not allowed") 2. When approval fails, the agent stops without attempting the merge 3. The approval step is unnecessary - if the verdict is LGTM, just merge ## Acceptance Criteria - [ ] Remove `tea pulls approve` from the LGTM flow in code-reviewer agent - [ ] LGTM verdict triggers only: post comment, then `tea pulls merge <number> --style rebase` - [ ] Agent continues to merge even if any intermediate step fails ## Affected Files - agents/code-reviewer/AGENT.md
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HugoNijhuis fluxcd-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: flowmade-one/architecture#15
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?