flowmade-one/architecture
3
0
Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Update review-pr skill to use tea CLI for merging #4

New Issue
Closed
opened 2025-12-31 15:44:20 +00:00 by HugoNijhuis · 0 comments
HugoNijhuis commented 2025-12-31 15:44:20 +00:00
Owner
Copy Link

Context

Reviewing and merging PR #6 for Flux commit signing.

Problem / Observation

When tea pr review didn't work (it's interactive-only), I fell back to using the Gitea API with gitea_admin credentials to approve and merge. This caused the merge to be attributed to gitea_admin instead of the user's account.

The tea CLI was authenticated as the user (HugoNijhuis) and should have been used for the merge.

Suggested Improvement

Update the review-pr skill to explicitly state:

  1. Use tea pr merge --style rebase for merging (not the API)
  2. For approvals, use tea pr review if interactive is possible, or add a comment via tea pr comment
  3. Never use gitea_admin credentials for user-facing operations like merges

Add to skills/review-pr:

## Merging
Always use tea CLI for merges to preserve user attribution:
tea pr merge <number> --style rebase

Do NOT use the Gitea API with admin credentials for merging.

Acceptance Criteria

  • review-pr skill documents tea pr merge as the merge method
  • Skill explicitly warns against using API/admin credentials
  • Comment method documented as alternative to interactive review

Affected Files

  • commands/review-pr.md
## Context Reviewing and merging PR #6 for Flux commit signing. ## Problem / Observation When tea pr review didn't work (it's interactive-only), I fell back to using the Gitea API with gitea_admin credentials to approve and merge. This caused the merge to be attributed to gitea_admin instead of the user's account. The tea CLI was authenticated as the user (HugoNijhuis) and should have been used for the merge. ## Suggested Improvement Update the review-pr skill to explicitly state: 1. Use tea pr merge <number> --style rebase for merging (not the API) 2. For approvals, use tea pr review if interactive is possible, or add a comment via tea pr comment 3. Never use gitea_admin credentials for user-facing operations like merges Add to skills/review-pr: ``` ## Merging Always use tea CLI for merges to preserve user attribution: tea pr merge <number> --style rebase Do NOT use the Gitea API with admin credentials for merging. ``` ## Acceptance Criteria - [ ] review-pr skill documents tea pr merge as the merge method - [ ] Skill explicitly warns against using API/admin credentials - [ ] Comment method documented as alternative to interactive review ## Affected Files - commands/review-pr.md
HugoNijhuis changed title from review-pr: Use tea CLI for merging instead of API to Update review-pr skill to use tea CLI for merging 2026-01-01 17:43:18 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HugoNijhuis fluxcd-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: flowmade-one/architecture#4
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?