flowmade-one/architecture
3
0
Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Enhance /review-pr with software architecture review #60

New Issue
Closed
opened 2026-01-09 22:59:47 +00:00 by HugoNijhuis · 0 comments
HugoNijhuis commented 2026-01-09 22:59:47 +00:00
Owner
Copy Link

Summary

Enhance the existing /review-pr command to include software architecture review as part of the standard PR review process for code PRs.

Acceptance Criteria

  • /review-pr command references software-architecture skill
  • Spawns software-architect agent for architectural analysis
  • Checks pattern consistency with existing codebase
  • Verifies dependency direction is correct
  • Flags breaking changes or API changes
  • Assesses impact on module boundaries
  • Checks error handling follows patterns
  • Includes both code review and architecture review in feedback

Context

Currently /review-pr does code review only. This enhancement adds software architecture review as a standard part of the process for all code PRs.

Dependencies

  • Depends on #56 (software-architecture skill)
  • Depends on #57 (software-architect agent)

Technical Notes

The review should be structured with two sections:

  1. Standard code review (quality, bugs, style, tests)
  2. Software architecture review (patterns, dependencies, breaking changes, module boundaries)

This is a modification to commands/review-pr.md, not a new command.

## Summary Enhance the existing `/review-pr` command to include software architecture review as part of the standard PR review process for code PRs. ## Acceptance Criteria - [ ] `/review-pr` command references software-architecture skill - [ ] Spawns software-architect agent for architectural analysis - [ ] Checks pattern consistency with existing codebase - [ ] Verifies dependency direction is correct - [ ] Flags breaking changes or API changes - [ ] Assesses impact on module boundaries - [ ] Checks error handling follows patterns - [ ] Includes both code review and architecture review in feedback ## Context Currently `/review-pr` does code review only. This enhancement adds software architecture review as a standard part of the process for all code PRs. ## Dependencies - Depends on #56 (software-architecture skill) - Depends on #57 (software-architect agent) ## Technical Notes The review should be structured with two sections: 1. Standard code review (quality, bugs, style, tests) 2. Software architecture review (patterns, dependencies, breaking changes, module boundaries) This is a modification to `commands/review-pr.md`, not a new command.
HugoNijhuis added a new dependency 2026-01-09 23:00:01 +00:00
#56 Create software-architecture skill
HugoNijhuis added a new dependency 2026-01-09 23:00:01 +00:00
#57 Create software-architect agent
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HugoNijhuis fluxcd-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Depends on
#56 Create software-architecture skill
flowmade-one/architecture
#57 Create software-architect agent
flowmade-one/architecture
Reference: flowmade-one/architecture#60
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?