flowmade-one/architecture
3
0
Fork 0
Code Issues 15 Pull Requests 1 Actions Packages Projects Releases Wiki Activity

Fix code-reviewer agent: heredoc comment bug and missing branch cleanup #62

New Issue
Closed
opened 2026-01-09 23:44:40 +00:00 by HugoNijhuis · 0 comments
HugoNijhuis commented 2026-01-09 23:44:40 +00:00
Owner
Copy Link

Summary

The code-reviewer agent has two bugs discovered during spawn-issues orchestration:

  1. Uses heredoc syntax with tea comment which causes the command to be backgrounded and fail silently
  2. Does not clean up branches after merging PRs

Acceptance Criteria

  • code-reviewer agent avoids heredoc syntax $(cat <<'EOF'...) with tea comment
  • code-reviewer agent calls tea pulls clean <number> after merging a PR
  • Agent prompt explicitly references the gitea skill warning about heredoc

Context

Discovered while running /spawn-issues 56. The reviewer:

  • Posted a detailed review comment using heredoc - it was backgrounded and never actually posted
  • Merged PR #61 successfully but left the branch on both local and remote

The gitea skill already documents this limitation:

Warning

: Do not use heredoc syntax $(cat <<'EOF'...EOF) with tea comment - it causes the command to be backgrounded and fail silently.

Technical Notes

Options for multi-line comments without heredoc:

  • Use simple inline strings with \n for newlines
  • Keep comments concise (single paragraph)
  • Use multiple tea comment calls if needed
## Summary The code-reviewer agent has two bugs discovered during spawn-issues orchestration: 1. Uses heredoc syntax with `tea comment` which causes the command to be backgrounded and fail silently 2. Does not clean up branches after merging PRs ## Acceptance Criteria - [ ] code-reviewer agent avoids heredoc syntax `$(cat <<'EOF'...)` with `tea comment` - [ ] code-reviewer agent calls `tea pulls clean <number>` after merging a PR - [ ] Agent prompt explicitly references the gitea skill warning about heredoc ## Context Discovered while running `/spawn-issues 56`. The reviewer: - Posted a detailed review comment using heredoc - it was backgrounded and never actually posted - Merged PR #61 successfully but left the branch on both local and remote The gitea skill already documents this limitation: > **Warning**: Do not use heredoc syntax `$(cat <<'EOF'...EOF)` with `tea comment` - it causes the command to be backgrounded and fail silently. ## Technical Notes Options for multi-line comments without heredoc: - Use simple inline strings with `\n` for newlines - Keep comments concise (single paragraph) - Use multiple `tea comment` calls if needed
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
HugoNijhuis fluxcd-bot renovate-bot
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: flowmade-one/architecture#62
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?