Create the software-architect agent that performs architectural analysis. This agent is spawned by commands for deep, isolated analysis and uses the software-architecture skill.
Changes
Add agents/software-architect/agent.md with full agent definition
Agent references software-architecture skill in frontmatter
Supports three analysis types: repo-audit, issue-refine, pr-review
Defines process for gathering information based on analysis type
Applies architectural review checklists from the skill
## Summary
Create the software-architect agent that performs architectural analysis. This agent is spawned by commands for deep, isolated analysis and uses the software-architecture skill.
## Changes
- Add `agents/software-architect/agent.md` with full agent definition
- Agent references software-architecture skill in frontmatter
- Supports three analysis types: repo-audit, issue-refine, pr-review
- Defines process for gathering information based on analysis type
- Applies architectural review checklists from the skill
- Identifies anti-patterns (god packages, circular dependencies, leaky abstractions, etc.)
- Generates prioritized recommendations (P0 Critical to P3 Low)
- Returns structured ARCHITECT_ANALYSIS_RESULT output for calling commands to parse
## Acceptance Criteria Met
- [x] Agent file created at agents/software-architect/agent.md
- [x] Agent references software-architecture skill in frontmatter
- [x] Agent can analyze codebase structure and patterns
- [x] Agent applies architectural review checklists from the skill
- [x] Agent identifies anti-patterns and concerns
- [x] Agent generates prioritized recommendations
- [x] Agent returns structured results for calling commands to parse
Closes #57
Create the software-architect agent that performs deep architectural
analysis on codebases. The agent:
- References software-architecture skill for patterns and checklists
- Supports three analysis types: repo-audit, issue-refine, pr-review
- Analyzes codebase structure and patterns
- Applies architectural review checklists from the skill
- Identifies anti-patterns (god packages, circular deps, etc.)
- Generates prioritized recommendations (P0-P3)
- Returns structured ARCHITECT_ANALYSIS_RESULT for calling commands
Closes#57
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This is an automated review generated by the code-reviewer agent.
Summary
The software-architect agent is well-designed with clear structure and comprehensive coverage of architectural analysis scenarios. The agent properly references the software-architecture skill and follows the repository's agent patterns. Minor improvements would enhance clarity around input handling and tool usage consistency.
Findings
Code Quality
agents/software-architect/agent.md:26-28 - Input variables (ANALYSIS_TYPE, TARGET, CONTEXT) are well-documented but it's unclear how the calling command should pass these. Consider adding a note about expected input format (as variables in the agent invocation context, or as part of the prompt).
agents/software-architect/agent.md:42-48 - The bash examples use find commands, but the frontmatter includes Glob tool which would be more appropriate. Consider updating examples to use Glob tool instead of find for file discovery.
agents/software-architect/agent.md:7 - Good choice to list tools explicitly. The disallowedTools section correctly prevents file modification which aligns with the analysis-only purpose.
The three-phase analysis structure (Gather → Analyze → Report) is clear and well-organized.
Potential Bugs
agents/software-architect/agent.md:48 - The find command examples could fail silently if directories don't exist. The existing 2>/dev/null for some commands is good, but should be applied consistently or better yet, use Glob tool which handles errors gracefully.
No obvious logic errors in the analysis flow.
Security Concerns
No security concerns identified. The agent is read-only which is appropriate for architectural analysis.
Style Notes
agents/software-architect/agent.md:43 - Minor inconsistency: some ls commands have -la flags, others don't. Standardize for consistency.
agents/software-architect/agent.md:110-184 - The output format section is excellent and well-structured. The ARCHITECT_ANALYSIS_RESULT header makes it easy for calling commands to parse.
Consistent with other agents in the repository (code-reviewer, issue-worker).
Test Coverage
N/A for agent definition files. The agent's effectiveness will be validated through usage.
Consider documenting expected behavior with test cases or example outputs in the learnings/ directory after first use.
Verdict
LGTM
This agent is well-crafted and ready to merge. It properly leverages the software-architecture skill, follows repository conventions, and provides a structured approach to architectural analysis. The input/output contracts are clear, making it easy for commands to invoke and parse results. Minor suggestions above are for future refinement, not blockers.
## AI Code Review
> This is an automated review generated by the code-reviewer agent.
### Summary
The software-architect agent is well-designed with clear structure and comprehensive coverage of architectural analysis scenarios. The agent properly references the software-architecture skill and follows the repository's agent patterns. Minor improvements would enhance clarity around input handling and tool usage consistency.
### Findings
#### Code Quality
- **agents/software-architect/agent.md:26-28** - Input variables (ANALYSIS_TYPE, TARGET, CONTEXT) are well-documented but it's unclear how the calling command should pass these. Consider adding a note about expected input format (as variables in the agent invocation context, or as part of the prompt).
- **agents/software-architect/agent.md:42-48** - The bash examples use find commands, but the frontmatter includes Glob tool which would be more appropriate. Consider updating examples to use Glob tool instead of find for file discovery.
- **agents/software-architect/agent.md:7** - Good choice to list tools explicitly. The disallowedTools section correctly prevents file modification which aligns with the analysis-only purpose.
- The three-phase analysis structure (Gather → Analyze → Report) is clear and well-organized.
#### Potential Bugs
- **agents/software-architect/agent.md:48** - The find command examples could fail silently if directories don't exist. The existing 2>/dev/null for some commands is good, but should be applied consistently or better yet, use Glob tool which handles errors gracefully.
- No obvious logic errors in the analysis flow.
#### Security Concerns
- No security concerns identified. The agent is read-only which is appropriate for architectural analysis.
#### Style Notes
- **agents/software-architect/agent.md:43** - Minor inconsistency: some ls commands have -la flags, others don't. Standardize for consistency.
- **agents/software-architect/agent.md:110-184** - The output format section is excellent and well-structured. The ARCHITECT_ANALYSIS_RESULT header makes it easy for calling commands to parse.
- Consistent with other agents in the repository (code-reviewer, issue-worker).
#### Test Coverage
- N/A for agent definition files. The agent's effectiveness will be validated through usage.
- Consider documenting expected behavior with test cases or example outputs in the learnings/ directory after first use.
### Verdict
**LGTM**
This agent is well-crafted and ready to merge. It properly leverages the software-architecture skill, follows repository conventions, and provides a structured approach to architectural analysis. The input/output contracts are clear, making it easy for commands to invoke and parse results. Minor suggestions above are for future refinement, not blockers.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Summary
Create the software-architect agent that performs architectural analysis. This agent is spawned by commands for deep, isolated analysis and uses the software-architecture skill.
Changes
agents/software-architect/agent.mdwith full agent definitionAcceptance Criteria Met
Closes #57
AI Code Review
Summary
The software-architect agent is well-designed with clear structure and comprehensive coverage of architectural analysis scenarios. The agent properly references the software-architecture skill and follows the repository's agent patterns. Minor improvements would enhance clarity around input handling and tool usage consistency.
Findings
Code Quality
Potential Bugs
Security Concerns
Style Notes
Test Coverage
Verdict
LGTM
This agent is well-crafted and ready to merge. It properly leverages the software-architecture skill, follows repository conventions, and provides a structured approach to architectural analysis. The input/output contracts are clear, making it easy for commands to invoke and parse results. Minor suggestions above are for future refinement, not blockers.