[Issue #18] Add /commit command #78

Merged
HugoNijhuis merged 1 commits from issue-18-add-commit-command into main 2026-01-10 18:20:29 +00:00
Owner

Summary

Add a new /commit command that streamlines the commit workflow by analyzing staged changes and generating conventional commit messages.

Changes

  • Add commands/commit.md with the commit workflow
  • Analyzes staged changes via git diff --staged
  • Generates conventional commit messages (feat:, fix:, refactor:, docs:, etc.)
  • Presents message for user approval/edit before committing
  • Respects partial staging (only commits staged changes)

Closes #18

## Summary Add a new `/commit` command that streamlines the commit workflow by analyzing staged changes and generating conventional commit messages. ## Changes - Add `commands/commit.md` with the commit workflow - Analyzes staged changes via `git diff --staged` - Generates conventional commit messages (feat:, fix:, refactor:, docs:, etc.) - Presents message for user approval/edit before committing - Respects partial staging (only commits staged changes) Closes #18
HugoNijhuis added 1 commit 2026-01-10 18:18:50 +00:00
Add streamlined commit workflow that analyzes staged changes and
generates conventional commit messages (feat:, fix:, etc.) with
user approval before committing.

Closes #18

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Author
Owner

AI Code Review

This is an automated review generated by the code-reviewer agent.

Summary

This PR adds a well-structured /commit command that implements a conventional commit workflow with user approval. The implementation follows the repository's command patterns and provides clear guidance for generating standardized commit messages.

Findings

Code Quality

  • Code is well-structured and follows existing command patterns in the repository
  • The workflow steps are clear and logically organized
  • Good use of conventional commit format with comprehensive type definitions
  • The process respects partial staging, which is an important detail

Potential Bugs

  • No obvious bugs detected
  • The heredoc syntax for git commit is correct and matches examples in the repository
  • Proper handling of the no-staged-changes case with user guidance

Security Concerns

  • No security concerns identified
  • The command only works with git operations and user-approved content

Style Notes

  • Consistent with other command files in the repository (e.g., create-issue.md, work-issue.md)
  • Good use of markdown formatting for readability
  • The YAML frontmatter follows the established pattern

Test Coverage

  • As a command definition file (markdown), automated tests are not applicable
  • The command can be manually tested by using /commit in Claude Code

Documentation Quality

  • Excellent documentation of the conventional commit format
  • Clear examples of commit types with explanations
  • Good guidance on scope, description format, and imperative mood
  • Helpful next steps section after commit completion

Minor Suggestions

  1. Consider adding an example commit message in the documentation to illustrate the format
  2. The description guideline says 'Focus on the why when the what is obvious' - this could include a brief example showing good vs. less-good descriptions

Verdict

LGTM

This is a solid implementation that adds useful functionality to the workflow toolkit. The command is well-documented, follows conventional commit standards, and integrates cleanly with the existing command structure. Ready to merge.

## AI Code Review > This is an automated review generated by the code-reviewer agent. ### Summary This PR adds a well-structured /commit command that implements a conventional commit workflow with user approval. The implementation follows the repository's command patterns and provides clear guidance for generating standardized commit messages. ### Findings #### Code Quality - Code is well-structured and follows existing command patterns in the repository - The workflow steps are clear and logically organized - Good use of conventional commit format with comprehensive type definitions - The process respects partial staging, which is an important detail #### Potential Bugs - No obvious bugs detected - The heredoc syntax for git commit is correct and matches examples in the repository - Proper handling of the no-staged-changes case with user guidance #### Security Concerns - No security concerns identified - The command only works with git operations and user-approved content #### Style Notes - Consistent with other command files in the repository (e.g., create-issue.md, work-issue.md) - Good use of markdown formatting for readability - The YAML frontmatter follows the established pattern #### Test Coverage - As a command definition file (markdown), automated tests are not applicable - The command can be manually tested by using /commit in Claude Code ### Documentation Quality - Excellent documentation of the conventional commit format - Clear examples of commit types with explanations - Good guidance on scope, description format, and imperative mood - Helpful next steps section after commit completion ### Minor Suggestions 1. Consider adding an example commit message in the documentation to illustrate the format 2. The description guideline says 'Focus on the why when the what is obvious' - this could include a brief example showing good vs. less-good descriptions ### Verdict **LGTM** This is a solid implementation that adds useful functionality to the workflow toolkit. The command is well-documented, follows conventional commit standards, and integrates cleanly with the existing command structure. Ready to merge.
HugoNijhuis merged commit 065635694b into main 2026-01-10 18:20:29 +00:00
Sign in to join this conversation.
No Reviewers
No Label
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: flowmade-one/architecture#78