flowmade-one/tea - tea

6 Commits

Author	SHA1	Message	Date
Alain ThiffaultandLunny Xiao	5103496232	fix(pagination): replace Page:-1 with explicit pagination loops (#967 ) ## Summary \`Page: -1\` in the Gitea SDK calls \`setDefaults()\` which sets both \`Page=0\` and \`PageSize=0\`, resulting in \`?page=0&limit=0\` being sent to the server. The server interprets \`limit=0\` as "use server default" (typically 30 items via \`DEFAULT_PAGING_NUM\`), not "return everything". Any resource beyond the first page of results was silently invisible. This affected 8 call sites, with the most user-visible impact being \`tea issues edit --add-labels\` and \`tea pulls edit --add-labels\` silently failing to apply labels on repositories with more than ~30 labels. ## Affected call sites \| File \| API call \| User-visible impact \| \|---\|---\|---\| \| \`modules/task/labels.go\` \| \`ListRepoLabels\` \| \`issues/pulls edit --add-labels\` fails silently \| \| \`modules/interact/issue_create.go\` \| \`ListRepoLabels\` \| interactive label picker missing labels \| \| \`modules/task/pull_review_comment.go\` \| \`ListPullReviews\` \| review comments truncated \| \| \`modules/task/login_ssh.go\` \| \`ListMyPublicKeys\` \| SSH key auto-detection fails \| \| \`modules/task/login_create.go\` \| \`ListAccessTokens\` \| token name deduplication misses existing tokens \| \| \`cmd/pulls.go\` \| \`ListPullReviews\` \| PR detail view missing reviews \| \| \`cmd/releases/utils.go\` \| \`ListReleases\` \| tag lookup fails on repos with many releases \| \| \`cmd/attachments/delete.go\` \| \`ListReleaseAttachments\` \| attachment deletion fails when many attachments exist \| ## Fix Each call site is replaced with an explicit pagination loop that follows \`resp.NextPage\` until all pages are exhausted. Reviewed-on: https://gitea.com/gitea/tea/pulls/967 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>	2026-04-23 17:06:42 +00:00
Alain Thiffaultandtechknowlogick	bdf15a57be	feat(pulls): add JSON output support for single PR view (#864 ) Reviewed-on: https://gitea.com/gitea/tea/pulls/864 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>	2026-02-19 15:16:21 +00:00
Alain ThiffaultandLunny Xiao	7ab3366220	fix(labels): improve delete command and fix --id flag type (#865 ) ## Summary Fix the `tea labels delete` and `tea labels update` commands which were silently ignoring the `--id` flag. ## Problem Both commands used `IntFlag` for the `--id` parameter but called `ctx.Int64("id")` to retrieve the value. This type mismatch caused the ID to always be read as `0`, making the commands useless. Before (bug): ```bash $ tea labels delete --id 36 --debug DELETE: .../labels/0 # Wrong! ID ignored ``` After (fix): ```bash $ tea labels delete --id 36 --debug GET: .../labels/36 # Verify exists DELETE: .../labels/36 # Correct ID Label 'my-label' (id: 36) deleted successfully ``` ## Changes ### labels/delete.go - Change `IntFlag` to `Int64Flag` to match `ctx.Int64()` usage - Make `--id` flag required - Verify label exists before attempting deletion - Provide clear error messages with label name and ID context - Print success message after deletion ### labels/update.go - Change `IntFlag` to `Int64Flag` to fix the same bug ## Test plan - [x] `go test ./...` passes - [x] `go vet ./...` passes - [x] `gofmt` check passes - [x] Manual testing confirms ID is now correctly passed to API - [ ] CI passes Reviewed-on: https://gitea.com/gitea/tea/pulls/865 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>	2026-01-25 23:36:42 +00:00
Alain ThiffaultandLunny Xiao	68b9620b8c	fix: expose pagination flags for secrets list command (#853 ) goreleaser / goreleaser (push) Failing after 1m29s Details goreleaser / release-image (push) Failing after 2m54s Details The command uses flags.GetListOptions() internally but didn't expose --page and --limit flags to users, making pagination inaccessible. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/tea/pulls/853 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>	2025-12-05 06:14:41 +00:00
Alain ThiffaultandLunny Xiao	e961a8f01d	fix: expose pagination flags for webhooks list command (#852 ) The command uses flags.GetListOptions() internally but didn't expose --page and --limit flags to users, making pagination inaccessible. Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/tea/pulls/852 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>	2025-12-05 06:14:34 +00:00
Alain ThiffaultandLunny Xiao	f59430a42a	fix: pass pagination options to ListRepoPullRequests (#851 ) Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com> Reviewed-on: https://gitea.com/gitea/tea/pulls/851 Reviewed-by: Lunny Xiao <xiaolunwen@gmail.com> Co-authored-by: Alain Thiffault <athiffau@effectivemomentum.com> Co-committed-by: Alain Thiffault <athiffau@effectivemomentum.com>	2025-12-05 06:14:01 +00:00