Files

Hugo Nijhuis 8f0b50b9ce Enhance /review-pr with software architecture review

Add software architecture review as a standard part of PR review process:
- Reference software-architecture skill for patterns and checklists
- Spawn software-architect agent for architectural analysis
- Add checks for pattern consistency, dependency direction, breaking changes,
  module boundaries, and error handling
- Structure review output with separate Code Review and Architecture Review
  sections

Closes #60

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

2026-01-10 00:09:50 +00:00

2.3 KiB

Raw Blame History

description, argument-hint

description	argument-hint
Review a Gitea pull request. Fetches PR details, diff, and comments. Includes both code review and software architecture review.	<pr-number>

Review PR #$1

@~~/.claude/skills/gitea/SKILL.md @~~/.claude/skills/software-architecture/SKILL.md

1. Gather Information

View PR details with --comments flag to see description, metadata, and discussion

Get the diff to review the changes:

tea pulls checkout <number>
git diff main...HEAD

2. Code Review

Review the changes and provide feedback on:

Code quality and style
Potential bugs or logic errors
Test coverage
Documentation updates

3. Software Architecture Review

Spawn the software-architect agent for architectural analysis:

Use the Task tool to spawn the software-architect agent:
@~/.claude/agents/software-architect/agent.md

Provide context:
ANALYSIS_TYPE: pr-review
TARGET: <pr-number>
CONTEXT: [Include the PR diff and description]

The architecture review checks:

Pattern consistency: Changes follow existing codebase patterns
Dependency direction: Dependencies flow correctly (toward domain layer)
Breaking changes: API changes are flagged and justified
Module boundaries: Changes respect existing package boundaries
Error handling: Errors wrapped with context, proper error types used

4. Present Findings

Structure the review with two sections:

Code Review

Quality, bugs, style issues
Test coverage gaps
Documentation needs

Architecture Review

Summary of architectural concerns from agent
Pattern violations or anti-patterns detected
Dependency or boundary issues
Breaking change assessment

5. User Actions

Ask the user what action to take:

Merge: Post review summary as comment, then merge with rebase style
Request changes: Leave feedback without merging
Comment only: Add a comment for discussion

Merging

Always use tea CLI for merges to preserve user attribution:

tea pulls merge <number> --style rebase

For review comments, use tea comment since tea pulls review is interactive-only:

tea comment <number> "<review summary>"

Warning

: Never use the Gitea API with admin credentials for user-facing operations like merging. This causes the merge to be attributed to the admin account instead of the user.

2.3 KiB Raw Blame History